fix: Only register inequality comparisons for orderable types #11784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66909744 |
✅ Deploy Preview for meta-velox canceled.
|
|
According to the original PR that added these it was intended to add support for arrays and rows (maps weren't mentioned) so this seems in line with that. |
xiaoxmeng
approved these changes
Dec 7, 2024
…okincubator#11784) Summary: Inequalities only work with types that are orderable pretty much by definition. For maps in particular we allow users to call map1 < map2 but it will always throw because the map type does not support inequalities unless null is treated as a value (which it is not in GenericView's compare function which is what gets invoked). This will address facebookincubator#11549 where inequalities on maps can be generated in fuzzers and result in exceptions. Reviewed By: xiaoxmeng Differential Revision: D66909744
kevinwilfong
force-pushed
the
export-D66909744
branch
from
68ba234 to
cf02306
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66909744 |
|
This pull request has been merged in 5739a6d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Inequalities only work with types that are orderable pretty much by definition.
For maps in particular we allow users to call map1 < map2 but it will always throw because the map
type does not support inequalities unless null is treated as a value (which it is not in GenericView's
compare function which is what gets invoked).
This will address #11549 where inequalities on
maps can be generated in fuzzers and result in exceptions.
Differential Revision: D66909744